Conversation
vshanthe
requested review from
yec-akamai,
ykim-akamai and
zliang-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Jun 13, 2025
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tests are passing locally! Do we want to merge this into a project branch rather than dev so that we can release it along with the other projects?
ykim-akamai
reviewed
Jun 26, 2025
|
|
||
| settings_text = ( | ||
| exec_test_command(BASE_CMDS + ["settings", "--text", "--delimiter=,"]) | ||
| .stdout.decode() |
Contributor
There was a problem hiding this comment.
stdout.decode.rstrip() no longer needed for exec_test_command helper
ykim-akamai
approved these changes
Jun 26, 2025
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM after addressing comment above. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added tests for changes introduced by the Linode Interfaces epic, covering updates to Account and Networking API endpoints
✔️ How to Test
make test-int TEST_SUITE=account
make test-int TEST_SUITE=networking
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.